Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2666)

Issue 2847012: Fix tests/Makefile (Closed)

Created:
10 years, 6 months ago by vb
Modified:
9 years, 6 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/vboot_reference.git
Visibility:
Public.

Description

This CL makes sure that the tests dirctory Makefile works properly, i.e. rebuild relevant targets if any of the dependencies (implicit or explicit) change. To make dependency generation easier the three source files in the tests directory shared among many programs (rollback_index_mock.c test_common.c timer_utils.c and crc32_test.c) are separated into a library, with each of them getting its own the automated dependency script generated by the compiler. To simplify rule definitions, all applications built in the test directory get linked with -lcrypto and -lrt, which is not a problem as the linker will not use the library unless needed. Tested by touching different .h and .c files in ./tests, running make and then and observing the make results. Also verified that emerging works for x86 in chroot environment.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -81 lines) Patch
M tests/Makefile View 4 chunks +22 lines, -81 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vb
10 years, 6 months ago (2010-06-16 20:08:14 UTC) #1
Bill Richardson
10 years, 6 months ago (2010-06-16 20:50:18 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698