remoting/host/capturer.cc - Issue 2847010: Coverity: Fix undefined assignment evaluation order in remoting::Capturer::FinishCapture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/capturer.cc

Issue 2847010: Coverity: Fix undefined assignment evaluation order in remoting::Capturer::FinishCapture. (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "remoting/host/capturer.h"	5 #include "remoting/host/capturer.h"

6	6

7 namespace remoting {	7 namespace remoting {

8	8

9 Capturer::Capturer()	9 Capturer::Capturer()

10 : width_(0),	10 : width_(0),

(...skipping 25 matching lines...) Expand all Loading...
36	36

37 void Capturer::InvalidateRect(gfx::Rect dirty_rect) {	37 void Capturer::InvalidateRect(gfx::Rect dirty_rect) {

38 inval_rects_.push_back(dirty_rect);	38 inval_rects_.push_back(dirty_rect);

39 }	39 }

40	40

41 void Capturer::FinishCapture(Task* done_task) {	41 void Capturer::FinishCapture(Task* done_task) {

42 done_task->Run();	42 done_task->Run();

43 delete done_task;	43 delete done_task;

44	44

45 // Select the next buffer to be the current buffer.	45 // Select the next buffer to be the current buffer.

46 current_buffer_ = ++current_buffer_ % kNumBuffers;	46 current_buffer_ = (current_buffer_ + 1) % kNumBuffers;

47 }	47 }

48	48

49 } // namespace remoting	49 } // namespace remoting

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »