net/data/ftp/dir-listing-ls-17 - Issue 2846037: Fix a renderer crash while processing FTP directory listing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/ftp/dir-listing-ls-17

Issue 2846037: Fix a renderer crash while processing FTP directory listing. (Closed)

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 ftpd-BSD: .: Permission denied
	wtc 2010/06/26 17:44:37 Just curious: could you explain why this input cau Just curious: could you explain why this input causes the parser's OnEndOfInput to fail? Paweł Hajdan Jr. 2010/06/28 16:58:49 Good question. My interpretation is that initially Show quoted text On 2010/06/26 17:44:37, wtc wrote: > Just curious: could you explain why this input causes the > parser's OnEndOfInput to fail? Good question. My interpretation is that initially current_parser_ becomes VMS. That's because other parsers are more strict at the beginning, but VMS gives even less predictable listing headers, so we accept everything as a potential header. But then VMS has a very specific footer. We use it to verify that it was really a VMS listing, and in this case it wasn't. wtc 2010/06/30 15:07:53 Thanks for the explanation. Sounds like you didn' Thanks for the explanation. Sounds like you didn't construct this test case. Is this test case based on a real FTP directory listing? Paweł Hajdan Jr. 2010/06/30 15:19:54 Yes, that's the exact listing from the bug. Show quoted text On 2010/06/30 15:07:53, wtc wrote: > Sounds like you didn't construct this test case. Is this test case > based on a real FTP directory listing? Yes, that's the exact listing from the bug.
OLD	NEW