Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: src/api.cc

Issue 2846012: Heap profiler: add a missing link between a function closure and shared function info. (Closed)
Patch Set: comments addressed Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « include/v8-profiler.h ('k') | src/checks.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4442 matching lines...) Expand 10 before | Expand all | Expand 10 after
4453 reinterpret_cast<const i::HeapGraphEdge*>(this)->type()); 4453 reinterpret_cast<const i::HeapGraphEdge*>(this)->type());
4454 } 4454 }
4455 4455
4456 4456
4457 Handle<Value> HeapGraphEdge::GetName() const { 4457 Handle<Value> HeapGraphEdge::GetName() const {
4458 IsDeadCheck("v8::HeapGraphEdge::GetName"); 4458 IsDeadCheck("v8::HeapGraphEdge::GetName");
4459 const i::HeapGraphEdge* edge = 4459 const i::HeapGraphEdge* edge =
4460 reinterpret_cast<const i::HeapGraphEdge*>(this); 4460 reinterpret_cast<const i::HeapGraphEdge*>(this);
4461 switch (edge->type()) { 4461 switch (edge->type()) {
4462 case i::HeapGraphEdge::CONTEXT_VARIABLE: 4462 case i::HeapGraphEdge::CONTEXT_VARIABLE:
4463 case i::HeapGraphEdge::INTERNAL:
4463 case i::HeapGraphEdge::PROPERTY: 4464 case i::HeapGraphEdge::PROPERTY:
4464 return Handle<String>(ToApi<String>(i::Factory::LookupAsciiSymbol( 4465 return Handle<String>(ToApi<String>(i::Factory::LookupAsciiSymbol(
4465 edge->name()))); 4466 edge->name())));
4466 case i::HeapGraphEdge::ELEMENT: 4467 case i::HeapGraphEdge::ELEMENT:
4467 return Handle<Number>(ToApi<Number>(i::Factory::NewNumberFromInt( 4468 return Handle<Number>(ToApi<Number>(i::Factory::NewNumberFromInt(
4468 edge->index()))); 4469 edge->index())));
4469 default: UNREACHABLE(); 4470 default: UNREACHABLE();
4470 } 4471 }
4471 return ImplementationUtilities::Undefined(); 4472 return ImplementationUtilities::Undefined();
4472 } 4473 }
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
4715 4716
4716 4717
4717 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) { 4718 char* HandleScopeImplementer::Iterate(ObjectVisitor* v, char* storage) {
4718 HandleScopeImplementer* thread_local = 4719 HandleScopeImplementer* thread_local =
4719 reinterpret_cast<HandleScopeImplementer*>(storage); 4720 reinterpret_cast<HandleScopeImplementer*>(storage);
4720 thread_local->IterateThis(v); 4721 thread_local->IterateThis(v);
4721 return storage + ArchiveSpacePerThread(); 4722 return storage + ArchiveSpacePerThread();
4722 } 4723 }
4723 4724
4724 } } // namespace v8::internal 4725 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « include/v8-profiler.h ('k') | src/checks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698