Heap profiler: add a missing link between a function closure and shared function info.

Heap profiler: add a missing link between a function closure and shared function info.

Committed: http://code.google.com/p/v8/source/detail?r=4891

[Søren Thygesen Gjesse, 2010-06-17 12:11:44]

LGTM

http://codereview.chromium.org/2846012/diff/1/5
File src/profile-generator.cc (right):

http://codereview.chromium.org/2846012/diff/1/5#newcode856
src/profile-generator.cc:856: new HeapGraphEdge(HeapGraphEdge::CONTEXT_VARIABLE,
name, this, entry));
How about moving the "new HeapGraphEdge(...)" into AddEdge and pass the four
arguments to it instead?

http://codereview.chromium.org/2846012/diff/1/7
File test/cctest/test-heap-profiler.cc (right):

http://codereview.chromium.org/2846012/diff/1/7#newcode589
test/cctest/test-heap-profiler.cc:589: "function non_compiled(x) { return x - 1;
}\n"
Maybe non_compiled -> compiled_lazy.

[mnaganov (inactive), 2010-06-17 12:53:57]

http://codereview.chromium.org/2846012/diff/1/5
File src/profile-generator.cc (right):

http://codereview.chromium.org/2846012/diff/1/5#newcode856
src/profile-generator.cc:856: new HeapGraphEdge(HeapGraphEdge::CONTEXT_VARIABLE,
name, this, entry));
On 2010/06/17 12:11:44, Søren Gjesse wrote:
> How about moving the "new HeapGraphEdge(...)" into AddEdge and pass the four
> arguments to it instead?

HeapGraphEdge constructor is overloaded, so I'll end up having two AddEdge
versions, and again will need to extract common code from them.

http://codereview.chromium.org/2846012/diff/1/7
File test/cctest/test-heap-profiler.cc (right):

http://codereview.chromium.org/2846012/diff/1/7#newcode589
test/cctest/test-heap-profiler.cc:589: "function non_compiled(x) { return x - 1;
}\n"
On 2010/06/17 12:11:44, Søren Gjesse wrote:
> Maybe non_compiled -> compiled_lazy.

A good point! Renamed to 'lazy'.