Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 2845030: Disabling the ChromeFrame reference build perf memory test as it causes a cra... (Closed)

Created:
10 years, 5 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Disabling the ChromeFrame reference build perf memory test as it causes a crash for subsequent test runs. Bug=47812 TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome_frame/test/perf/chrome_frame_perftest.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 5 months ago (2010-06-29 04:52:10 UTC) #1
amit
10 years, 5 months ago (2010-06-29 16:06:25 UTC) #2
ok

On Mon, Jun 28, 2010 at 9:52 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Disabling the ChromeFrame reference build perf memory test as it causes a
> crash
> for subsequent test runs.
>
> Bug=47812
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/2845030/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/perf/chrome_frame_perftest.cc
>
>
> Index: chrome_frame/test/perf/chrome_frame_perftest.cc
> ===================================================================
> --- chrome_frame/test/perf/chrome_frame_perftest.cc     (revision 51095)
> +++ chrome_frame/test/perf/chrome_frame_perftest.cc     (working copy)
> @@ -982,6 +982,7 @@
>  // TODO(iyengar)
>  // Revisit why the chrome frame dll does not unload correctly when this
> test is
>  // run.
> +// http://code.google.com/p/chromium/issues/detail?id=47812
>  TEST_F(RegularChromeFrameActiveXMemoryTest, DISABLED_MemoryTestUrls) {
>   // TODO(iyengar)
>   // We should use static pages to measure memory usage.
> @@ -996,7 +997,11 @@
>  typedef ChromeFrameActiveXMemoryTest<ChromeFrameMemoryTestReference>
>     ReferenceBuildChromeFrameActiveXMemoryTest;
>
> -TEST_F(ReferenceBuildChromeFrameActiveXMemoryTest, MemoryTestAboutBlank) {
> +// Disabled to investigate why the chrome frame dll does not unload while
> +// running this test.
> +// http://code.google.com/p/chromium/issues/detail?id=47812
> +TEST_F(ReferenceBuildChromeFrameActiveXMemoryTest,
> +       DISABLED_MemoryTestAboutBlank) {
>   char *urls[] = {"about:blank"};
>   RunTest("memory_about_blank_reference", urls, arraysize(urls));
>  }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698