Issue 2845027: Added about:about page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2845027: Added about:about page.... (Closed)

Created:
10 years, 5 months ago by Ryan Tseng

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Added about:about page. BUG=44699 TEST=Go to about:about, and see if About page loads. Check if links work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51038

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -0 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View		5 chunks	+63 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/functional/special_tabs.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nsylvain

10 years, 5 months ago (2010-06-28 18:05:33 UTC) #2

LGTM, you should write the original review link in your commit message.

http://codereview.chromium.org/2845027/diff/1/3
File chrome/common/url_constants.cc (right):

http://codereview.chromium.org/2845027/diff/1/3#newcode58
chrome/common/url_constants.cc:58: 
you have an extra empty line here

Expand Messages | Collapse Messages