Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2845025: Fixed memory leak in ExtensionsService. (Closed)

Created:
10 years, 6 months ago by akalin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fixed memory leak in ExtensionsService. Added coverage for disabled extensions in unit tests. BUG=none TEST=new unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50910

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Addressed asargent's comments, added tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -3 lines) Patch
M chrome/browser/extensions/extensions_service.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 1 2 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
akalin
+asargent for review
10 years, 6 months ago (2010-06-25 22:19:54 UTC) #1
asargent_no_longer_on_chrome
10 years, 6 months ago (2010-06-25 22:48:27 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698