Issue 2845022: Enables the new wrench menu by default on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2845022: Enables the new wrench menu by default on windows. (Closed)

Created:
10 years, 6 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Jay Civelli, dmazzoni

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Visibility:
Public.

Description

Enables the new wrench menu by default on windows. BUG=45734 TEST=make sure the new wrench menu works! Make sure and exer Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50893

Patch Set 1 #

Patch Set 2 : Fixed based merge #

Patch Set 3 : Fixed BrowserViewsAccessibilityTest.TestPageMenuAccObj #

Patch Set 4 : Fix include #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
M	chrome/browser/views/browser_views_accessibility_browsertest.cc	View	3	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/wrench_menu_model.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/interactive_ui/keyboard_access_uitest.cc	View		2 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

10 years, 6 months ago (2010-06-24 19:35:07 UTC) #3

Thanks for including me.

This looks fine. The only thing I notice is that pressing Left or Right closes
the menu but doesn't move focus. I'm not sure what should happen when there's
only one menu, so this is fine for now.

Expand Messages | Collapse Messages