Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2845006: Merge 57386 - 2010-04-09 Abhishek Arya <inferno@chromium.org>... (Closed)

Created:
10 years, 6 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 57386 - 2010-04-09 Abhishek Arya <inferno@chromium.org>; Reviewed by Adam Barth. Prevent HTTP responses served with JSON content type from being rendered as HTML. Test: http/tests/security/xss-DENIED-mime-type-execute-as-html.html * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isTextMIMEType): Render application/json as text/plain. * platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): Add a compile assert to prevent addition of new mime types in non-image types. 2010-04-09 Abhishek Arya <inferno@chromium.org>; Reviewed by Adam Barth. Test non-image and javascript mime types are not rendered as HTML. * http/tests/security/resources/send-mime-types.php: Added. * http/tests/security/xss-DENIED-mime-type-execute-as-html-expected.txt: Added. * http/tests/security/xss-DENIED-mime-type-execute-as-html.html: Added. BUG=38105 TEST=NONE TBR=abarth@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
A LayoutTests/http/tests/security/resources/send-mime-types.php View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M WebCore/dom/DOMImplementation.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M WebCore/platform/MIMETypeRegistry.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 6 months ago (2010-06-15 22:05:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698