Issue 2845002: added support for an alternative ssh port for autotest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2845002: added support for an alternative ssh port for autotest (Closed)

Created:
10 years, 6 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
petkov, ericli

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/crosutils.git

Visibility:
Public.

Description

added support for an alternative ssh port for autotest (needed for running autotest on Vibrant VM)

Patch Set 2 : removed extra changes #

Patch Set 4 : minor fixes #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	remote_access.sh	View	1 2 3	2 chunks	+3 lines, -1 line	0 comments	Download
	M	run_remote_tests.sh	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zel

This change is needed for running autotest on Vibrant VM and any other VM that ...

10 years, 6 months ago (2010-06-14 20:49:00 UTC) #1

petkov

+ericli since he's implemented the magic in the autotest script that propagates unknown options to ...

10 years, 6 months ago (2010-06-14 20:59:30 UTC) #2

zel

http://codereview.chromium.org/2845002/diff/4001/5001 File remote_access.sh (right): http://codereview.chromium.org/2845002/diff/4001/5001#newcode14 remote_access.sh:14: "SSH port of the remote machine of running Chromium ...

10 years, 6 months ago (2010-06-14 21:37:30 UTC) #3

ericli

10 years, 6 months ago (2010-06-14 22:04:47 UTC) #4

LGTM.

But what is the use case behind here?

On 2010/06/14 21:37:30, zel wrote:
> http://codereview.chromium.org/2845002/diff/4001/5001
> File remote_access.sh (right):
> 
> http://codereview.chromium.org/2845002/diff/4001/5001#newcode14
> remote_access.sh:14: "SSH port of the remote machine of running Chromium OS
> instance"
> On 2010/06/14 20:59:31, petkov wrote:
> > nit: s/machine of running/machine running/
> > 
> 
> Done.