Issue 2844030: LiveEdit: Support debug break slots in frame dropping implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2844030: LiveEdit: Support debug break slots in frame dropping implementation (Closed)

Created:
10 years, 6 months ago by Peter Rybin

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

LiveEdit: Support debug break slots in frame dropping implementation Committed: http://code.google.com/p/v8/source/detail?r=4995

Patch Set 1 #

Patch Set 2 : clea #

Patch Set 3 : clean #

Patch Set 4 : mistype #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -13 lines)			Patch
M	src/debug.h	View	1 2 3	2 chunks	+19 lines, -3 lines	0 comments	Download
M	src/debug.cc	View	1 2 3	3 chunks	+17 lines, -6 lines	0 comments	Download
M	src/liveedit.cc	View	1 2 3	4 chunks	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

Hi Soren I think I should support dropping the stack when it's on debug break ...

10 years, 5 months ago (2010-06-28 16:28:23 UTC) #1

Søren Thygesen Gjesse

10 years, 5 months ago (2010-06-29 10:10:17 UTC) #2

LGTM

>> By the way, since debug break slot simply does "call ***", why 
>> the stub it calls makes jump rather than simply do return?

Continuing from a break point is always handled by making a jump, which is also
the case for break at debug break slots.

Expand Messages | Collapse Messages