Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 2844030: LiveEdit: Support debug break slots in frame dropping implementation (Closed)

Created:
10 years, 6 months ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

LiveEdit: Support debug break slots in frame dropping implementation Committed: http://code.google.com/p/v8/source/detail?r=4995

Patch Set 1 #

Patch Set 2 : clea #

Patch Set 3 : clean #

Patch Set 4 : mistype #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M src/debug.h View 1 2 3 2 chunks +19 lines, -3 lines 0 comments Download
M src/debug.cc View 1 2 3 3 chunks +17 lines, -6 lines 0 comments Download
M src/liveedit.cc View 1 2 3 4 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Rybin
Hi Soren I think I should support dropping the stack when it's on debug break ...
10 years, 5 months ago (2010-06-28 16:28:23 UTC) #1
Søren Thygesen Gjesse
10 years, 5 months ago (2010-06-29 10:10:17 UTC) #2
LGTM

>> By the way, since debug break slot simply does "call ***", why 
>> the stub it calls makes jump rather than simply do return?

Continuing from a break point is always handled by making a jump, which is also
the case for break at debug break slots.

Powered by Google App Engine
This is Rietveld 408576698