Ignore TPM return codes in recovery mode

Ignore TPM return codes in recovery mode

[Luigi Semenzato, 2010-06-24 20:18:43]

LGTM

Optionally you may want to consider a couple of comments below.

http://codereview.chromium.org/2844024/diff/1/3
File firmware/lib/vboot_kernel.c (right):

http://codereview.chromium.org/2844024/diff/1/3#newcode138
firmware/lib/vboot_kernel.c:138: if (0 != RollbackKernelRecovery(is_dev ? 1 :
0)) {
If our convention for booleans is 0 for false, and anything else for true, you
could just pass is_dev here.  That seems to be the convention based on your use
below.

http://codereview.chromium.org/2844024/diff/1/3#newcode376
firmware/lib/vboot_kernel.c:376: /* Lock the kernel versions */
I think that here we may want to invert the conditionals.  We don't want to lock
PP in recovery mode.

Oh I see.  I already take care of that in RollbackKernelLock.  So you don't
really have to check for is_rec, because in that case the Lock call is a noop,
which is always successful.

Either way is fine.

[indonasty23, 2016-01-13 10:13:52]

indonasty23@gmail.com changed reviewers:
+ indonasty23@gmail.com

[indonasty23, 2016-01-13 10:13:52]

lgtm

[indonasty23, 2016-01-13 11:15:47]

lgtm

[indonasty23, 2016-01-13 12:48:38]

lgtm