Issue 2843060: GYP changed to extract D3DX9 DLL into product dir....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2843060: GYP changed to extract D3DX9 DLL into product dir.... (Closed)

Created:
10 years, 5 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GYP changed to extract D3DX9 DLL into product dir. This is so ANGLE will find it. Also added ANGLE as a Chrome dependency. There must be a better way to detect whether there is a directxsdk directory in third_party. I'm open to ideas. TEST=try, check d3dx9 is copied to product dir when building chrome, check ANGLE initializes BUG=45898 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53076

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -1 line)			Patch
M	build/all.gyp	View		2 chunks	+1 line, -1 line	0 comments	Download
A	build/dir_exists.py	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages