Issue 2843054: Implement AutomationProvider::WindowGetViewBounds() for...

Issue 2843054: Implement AutomationProvider::WindowGetViewBounds() for... (Closed)

Created:
10 years, 5 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Joe, Paweł Hajdan Jr.

CC:
chromium-reviews, ben+cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Implement AutomationProvider::WindowGetViewBounds() for VIEW_ID_TAB_CONTAINER only to help WebDriver doodz. BUG=none TESTS=WebDriver doodz say things work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55011

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -4 lines)			Patch
	M	chrome/browser/automation/automation_provider_mac.mm	View	1	2 chunks	+33 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

Joe will be testing this change on his machine. Joe will describe his tests in ...

10 years, 5 months ago (2010-07-15 23:42:35 UTC) #1

Paweł Hajdan Jr.

Drive-by with a minor automation comment. http://codereview.chromium.org/2843054/diff/1/2 File chrome/browser/automation/automation_provider_mac.mm (right): http://codereview.chromium.org/2843054/diff/1/2#newcode61 chrome/browser/automation/automation_provider_mac.mm:61: if (view_id != ...

10 years, 5 months ago (2010-07-16 00:16:00 UTC) #2

John Grabowski

http://codereview.chromium.org/2843054/diff/1/2 File chrome/browser/automation/automation_provider_mac.mm (right): http://codereview.chromium.org/2843054/diff/1/2#newcode61 chrome/browser/automation/automation_provider_mac.mm:61: if (view_id != VIEW_ID_TAB_CONTAINER) On 2010/07/16 00:16:00, Paweł Hajdan ...

10 years, 5 months ago (2010-07-16 00:25:25 UTC) #3

John Grabowski

On 2010/07/16 00:29:59, Paweł Hajdan Jr. wrote: > Code I commented in the drive-by LGTM. ...

10 years, 5 months ago (2010-07-27 23:31:34 UTC) #5

Joe

It works fine for webdriver On 2010/07/27 23:31:34, John Grabowski wrote: > On 2010/07/16 00:29:59, ...

10 years, 4 months ago (2010-08-03 17:34:58 UTC) #6

John Grabowski

On 2010/08/03 17:34:58, Joe wrote: > It works fine for webdriver > > On 2010/07/27 ...

10 years, 4 months ago (2010-08-04 04:51:08 UTC) #7

Joe

10 years, 4 months ago (2010-08-04 20:50:02 UTC) #8

LGTM

On Tue, Aug 3, 2010 at 9:51 PM,  <jrg@chromium.org> wrote:
> On 2010/08/03 17:34:58, Joe wrote:
>>
>> It works fine for webdriver
>
>> On 2010/07/27 23:31:34, John Grabowski wrote:
>> > On 2010/07/16 00:29:59, Paweł Hajdan Jr. wrote:
>> > > Code I commented in the drive-by LGTM.
>> >
>> > ping joe
>
> What's the hold-up?  The longer you sit on this the more likely it gets
> stale
> and/or lost.
> Do you have concerns with this CL or not?
>
>
> http://codereview.chromium.org/2843054/show
>

Expand Messages | Collapse Messages