Fork a copy of all the notifier code in chrome/common/net/notifier that we depend on.

Fork a copy of all the notifier code in chrome/common/net/notifier that we depend on.

This breaks a cycle int the build dependencies so that we can keep moving forward on
Chromoting implementation.

BUG=none
TEST=compiles on mac/linux/win

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50959

[awong, 2010-06-26 01:13:54]

I hate this patch.  I really do.

But I'm hating being blocked as long as we have been (nearing 2 weeks) because
of build silliness more.

I've started a separate thread on how to unfork and do this right, but assuming
this passes try-bots, would love to check this in and get us moving.

[Sergey Ulanov, 2010-06-26 02:08:47]

Can we just compile these two classes as part of jingle_glue (i.e. add
chrome/common/net/notifier/communicator/*_socket_adapter.* to sources), without
copying the files?

If you do copy the files, please also apply this change:
http://codereview.chromium.org/2834024/show . It fixes an intermittent issues on
mac.

[awong, 2010-06-26 10:03:04]

We probably could, but it seems like a bad idea to have gyp sources from
files outside our directory tree.  I'd rather fork than do that.

On the otherhand, it sounds like moving these files into net is pretty near,
so this is a short-term (~1 week) hack.

-Albert


On Fri, Jun 25, 2010 at 7:08 PM, <sergeyu@chromium.org> wrote:

> Can we just compile these two classes as part of jingle_glue (i.e. add
> chrome/common/net/notifier/communicator/*_socket_adapter.* to sources),
> without
> copying the files?
>
> If you do copy the files, please also apply this change:
> http://codereview.chromium.org/2834024/show . It fixes an intermittent
> issues on
> mac.
>
>
>
> http://codereview.chromium.org/2843026/show
>

[Sergey Ulanov, 2010-06-27 06:28:14]

LGTM