Avoid a potential null dereference wrt the CPU profiler....

Avoid a potential null dereference wrt the CPU profiler.

GetActiveProfilerModules()/PauseProfiler()/ResumeProfiler() can be reached
from the API when the --prof runtime flag is not set, leading to null
dereferences. Verify that Logger::profiler_ is non-NULL before using it.


Committed: http://code.google.com/p/v8/source/detail?r=4953

[zarko, 2010-06-24 23:13:21]

This is the patch for the Logger bug from
http://codereview.chromium.org/2841023/show ported to bleeding_edge.

Thanks
  Luke

http://codereview.chromium.org/2843023/diff/1/2
File src/log.cc (right):

http://codereview.chromium.org/2843023/diff/1/2#newcode310
src/log.cc:310: void Profiler::Run() {
Would it be helpful to ASSERT(Logger::profiler_ == this)?

[mnaganov (inactive), 2010-06-25 09:14:56]

LGTM

On 2010/06/24 23:13:21, zarko wrote:
> This is the patch for the Logger bug from
> http://codereview.chromium.org/2841023/show ported to bleeding_edge.
> 
> Thanks
>   Luke
> 
> http://codereview.chromium.org/2843023/diff/1/2
> File src/log.cc (right):
> 
> http://codereview.chromium.org/2843023/diff/1/2#newcode310
> src/log.cc:310: void Profiler::Run() {
> Would it be helpful to ASSERT(Logger::profiler_ == this)?