Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Issue 2842063: Update Breakpad from r627 to r628 (Closed)

Created:
10 years, 5 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
dmac
CC:
chromium-reviews
Visibility:
Public.

Description

Update Breakpad from r627 to r628 to pick up: Separate the "hello" message from the parameter messages in Inspector::ReadMessages as was done before r627. The "hello" message contains the parameter count and is referenced while the message reader loops through parameter messages. Prior to r627, both messages were named |message|, which was confusing, probably caused a compiler warning, and apparently provided the motivation to share them. This caused the crash inspector to fail to properly collect the parameters. The common failure mode (although others are possible) was for the inspector to attempt tor read more parameter messages than were available, resulting in an IPC timeout and inspector death. No crash report would be written, and the application expecting its crash to be inspected would time out waiting for a response from the inspector and then _exit. Thisis effectively a failure to properly handle crashes. The inner message is reintroduced, and named parameter_message for disambiguation. BUG=49821 TEST= - Crashes catchable by the Mac Breakpad framework. - about:crash and its browser equivalent works and produces crash dumps in ~/Library/Breakpad/Chrome_Mac Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
TBR (Chrome dev channel blocker)
10 years, 5 months ago (2010-07-21 21:25:24 UTC) #1
dmac
10 years, 5 months ago (2010-07-21 22:05:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698