Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2842062: AutoFill: Record whether the user initiated the form submission and don't save form data if the form (Closed)

Created:
10 years, 5 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

AutoFill: Record whether the user initiated the form submission and don't save form data if the form was not user-submitted. BUG=48225 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53350

Patch Set 1 #

Patch Set 2 : Fix test. #

Patch Set 3 : Relax DCHECK. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/autofill/autofill_manager.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/autofill/form_structure.cc View 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autofill/form_structure_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/form_manager.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/form_data.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
10 years, 5 months ago (2010-07-21 01:08:58 UTC) #1
dhollowa
10 years, 5 months ago (2010-07-21 16:01:01 UTC) #2
On 2010/07/21 01:08:58, James Hawkins wrote:
> 

LGTM.

Powered by Google App Engine
This is Rietveld 408576698