Issue 2842023: Fix up the modification of the flimflam upstart script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2842023: Fix up the modification of the flimflam upstart script (Closed)

Created:
10 years, 6 months ago by Nathan Williams

Modified:
9 years, 6 months ago

Reviewers:
Sam Leffler, DaleCurtis

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@chromiumos-git/crosutils.git

Visibility:
Public.

Description

Fix up the modification of the flimflam upstart script to handle changed command line arguments, and attempt to make it resilient in the face of future changes. TEST=Run script on fresh image; confirm that '-I eth_test' is present on the exec line of /etc/init/flimflam.conf

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	mod_for_test_scripts/100setupTestingInterface	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

LGTM On 2010/06/23 21:57:54, Nathan Williams wrote: >

10 years, 6 months ago (2010-06-23 22:38:26 UTC) #2

Sam Leffler

10 years, 6 months ago (2010-06-24 00:51:45 UTC) #3

Didn't remember about this stuff when I changed flimflam.conf.  LGTM but perhaps
we should setup flimflam.conf so it's more obvious this sort of thing is going
on--e.g. by adding a shell variable just for this purpose (and an accompanying
comment so it does get removed in some future cleanup).

Expand Messages | Collapse Messages