Fix the allocator dependency to respect win_use_allocator_shim variable....

Fix the allocator dependency to respect win_use_allocator_shim variable.

R=maruel
BUG=46311
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50890

[M-A Ruel, 2010-06-23 16:23:22]

lgtm assuming it works

http://codereview.chromium.org/2842021/diff/1/3
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/2842021/diff/1/3#newcode1653
chrome/chrome_tests.gypi:1653: ['OS=="win" and win_use_allocator_shim==1', {
that works without "1" ?

[Victor Wang, 2010-06-23 16:39:17]

http://codereview.chromium.org/2842021/diff/1/3
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/2842021/diff/1/3#newcode1653
chrome/chrome_tests.gypi:1653: ['OS=="win" and win_use_allocator_shim==1', {
On 2010/06/23 16:23:22, Marc-Antoine Ruel wrote:
> that works without "1" ?

Done.

[M-A Ruel, 2010-06-23 16:40:44]

http://codereview.chromium.org/2842021/diff/1/3
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/2842021/diff/1/3#newcode1653
chrome/chrome_tests.gypi:1653: ['OS=="win" and win_use_allocator_shim==1', {
On 2010/06/23 16:39:17, Victor Wang wrote:
> On 2010/06/23 16:23:22, Marc-Antoine Ruel wrote:
> > that works without "1" ?
> 
> Done.

That was a question, I'm not sure it does the expected behavior. And I meant the
difference between "1" and 1, not the lack of equality sign.

[Victor Wang, 2010-06-23 17:15:10]

http://codereview.chromium.org/2842021/diff/1/3
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/2842021/diff/1/3#newcode1653
chrome/chrome_tests.gypi:1653: ['OS=="win" and win_use_allocator_shim==1', {
On 2010/06/23 16:40:44, Marc-Antoine Ruel wrote:
> On 2010/06/23 16:39:17, Victor Wang wrote:
> > On 2010/06/23 16:23:22, Marc-Antoine Ruel wrote:
> > > that works without "1" ?
> > 
> > Done.
> 
> That was a question, I'm not sure it does the expected behavior. And I meant
the
> difference between "1" and 1, not the lack of equality sign.

My bad, thought you meant without ==1. win_use_allocator_shim is an integer, so
don't think it needs double quotes.

I will make sure it passes try bot before commit.

[M-A Ruel, 2010-06-25 18:16:51]

lgtm with nit

http://codereview.chromium.org/2842021/diff/10001/11002
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/2842021/diff/10001/11002#newcode1792
chrome/chrome_tests.gypi:1792: '<(allocator_target)',
nit: please fix alignment.