Allowed to construct a dbus::BusConnection object with NULL g_connection

chromeos/dbus/dbus.cc

 // Copyright (c) 2009 The Chromium OS Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/dbus.h"
 
 #include <dbus/dbus.h>
 #include <dbus/dbus-glib-bindings.h>
 #include <dbus/dbus-glib-lowlevel.h>
 #include <base/logging.h>
@@ skipping 47 matching lines @@
   // signals nor method calls.
   GetSystemBusConnection();
 
   ::DBusError error;
   ::dbus_error_init(&error);
 
   ::DBusGConnection* result = NULL;
   ::DBusConnection* raw_connection
         = ::dbus_connection_open_private(address, &error);
   if (!raw_connection) {
-    // TODO(yusukes): We should return an error rather than just abort().
-    LOG(FATAL) << "dbus_connection_open_private failed";
+    LOG(WARNING) << "dbus_connection_open_private failed: " << address;
+    return BusConnection(NULL);
   }
 
   if (!::dbus_bus_register(raw_connection, &error)) {
-    LOG(ERROR) << "dbus_bus_register failed";
+    LOG(ERROR) << "dbus_bus_register failed: "
+               << (error.message ? error.message : "Unknown Error.");
     ::dbus_error_free(&error);
+    // TODO(yusukes): We don't call dbus_connection_close() nor g_object_unref()
+    // here for now since these calls might interfare with IBusBus connections
+    // in libcros and Chrome. See the comment in ~InputMethodStatusConnection()
+    // function in platform/cros/chromeos_input_method.cc for details.
+    return BusConnection(NULL);
   }
   
   ::dbus_connection_setup_with_g_main(
       raw_connection, NULL /* default context */);
 
   // A reference count of |raw_connection| is transferred to |result|. You don't
   // have to (and should not) unref the |raw_connection|.
   result = ::dbus_connection_get_g_connection(raw_connection);
   CHECK(result);
 
@@ skipping 128 matching lines @@
   dbus_g_connection_register_g_object(connection.g_connection(), 
                                       service_path,
                                       object);
   return true;
 }
 
 
 
 }  // namespace dbus
 }  // namespace chromeos