Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 2842019: Allowed to construct a dbus::BusConnection object with NULL g_connection (Closed)

Created:
10 years, 6 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
Zachary Kuznia
CC:
chromium-os-reviews_chromium.org, satorux1
Base URL:
ssh://git@gitrw.chromium.org//common.git
Visibility:
Public.

Description

Allowed to construct a dbus::BusConnection object with NULL g_connection (just like dbus::Proxy) to fix TODO in the GetPrivateConnection function. BUG=none

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chromeos/dbus/dbus.h View 3 chunks +13 lines, -3 lines 0 comments Download
M chromeos/dbus/dbus.cc View 1 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yusuke Sato
10 years, 6 months ago (2010-06-23 06:22:02 UTC) #1
Zachary Kuznia
http://codereview.chromium.org/2842019/diff/1/2 File chromeos/dbus/dbus.cc (right): http://codereview.chromium.org/2842019/diff/1/2#newcode74 chromeos/dbus/dbus.cc:74: ::dbus_error_free(&error); I've seen this case hit, too. Could you ...
10 years, 6 months ago (2010-06-23 06:27:45 UTC) #2
Yusuke Sato
http://codereview.chromium.org/2842019/diff/1/2 File chromeos/dbus/dbus.cc (right): http://codereview.chromium.org/2842019/diff/1/2#newcode74 chromeos/dbus/dbus.cc:74: ::dbus_error_free(&error); On 2010/06/23 06:27:45, Zachary Kuznia wrote: > I've ...
10 years, 6 months ago (2010-06-23 06:52:08 UTC) #3
Zachary Kuznia
10 years, 6 months ago (2010-06-23 06:53:43 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698