Chromium Code Reviews

Issue 2841034: Disk cache: Switch the disk cache to use the cache_thread.... (Closed)

Created:
10 years, 5 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain, nsylvain, gavinp
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, John Grabowski, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disk cache: Switch the disk cache to use the cache_thread. Add an InFlightBackendIO class that handles posting of cacheoperations back and forth between the IO thread and the cachethread. BUG=26730 TEST=unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51456

Patch Set 1 #

Patch Set 2 : Fix tsan issues #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+1349 lines, -852 lines)
MM net/disk_cache/backend_impl.h View 10 chunks +40 lines, -9 lines 0 comments
M net/disk_cache/backend_impl.cc View 16 chunks +229 lines, -88 lines 2 comments
MM net/disk_cache/backend_unittest.cc View 11 chunks +66 lines, -14 lines 0 comments
MM net/disk_cache/disk_cache_test_base.h View 4 chunks +7 lines, -1 line 0 comments
MM net/disk_cache/disk_cache_test_base.cc View 5 chunks +26 lines, -7 lines 0 comments
MM net/disk_cache/entry_impl.h View 2 chunks +15 lines, -2 lines 0 comments
MM net/disk_cache/entry_impl.cc View 13 chunks +117 lines, -40 lines 0 comments
MM net/disk_cache/entry_unittest.cc View 12 chunks +33 lines, -25 lines 0 comments
MM net/disk_cache/eviction.cc View 3 chunks +3 lines, -3 lines 0 comments
MM net/disk_cache/file_posix.cc View 4 chunks +11 lines, -2 lines 0 comments
A net/disk_cache/in_flight_backend_io.h View 1 chunk +200 lines, -0 lines 0 comments
A net/disk_cache/in_flight_backend_io.cc View 1 chunk +448 lines, -0 lines 0 comments
A + net/disk_cache/in_flight_io.h View 4 chunks +56 lines, -301 lines 0 comments
A + net/disk_cache/in_flight_io.cc View 2 chunks +27 lines, -333 lines 0 comments
MM net/disk_cache/sparse_control.cc View 5 chunks +9 lines, -9 lines 0 comments
MM net/disk_cache/stress_cache.cc View 1 chunk +0 lines, -1 line 0 comments
MM net/net.gyp View 1 chunk +4 lines, -0 lines 0 comments
MM net/tools/crash_cache/crash_cache.cc View 12 chunks +25 lines, -5 lines 0 comments
MM net/tools/dump_cache/upgrade.cc View 6 chunks +33 lines, -12 lines 0 comments

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
I think this is it. The first patch set is what I commited last time.
10 years, 5 months ago (2010-07-01 21:06:56 UTC) #1
nsylvain
lgtm http://codereview.chromium.org/2841034/diff/17001/10003 File net/disk_cache/backend_impl.cc (right): http://codereview.chromium.org/2841034/diff/17001/10003#newcode442 net/disk_cache/backend_impl.cc:442: Trace("Backend destructor"); destructor?
10 years, 5 months ago (2010-07-01 22:46:09 UTC) #2
rvargas (doing something else)
10 years, 5 months ago (2010-07-01 22:54:48 UTC) #3 
Thanks.

http://codereview.chromium.org/2841034/diff/17001/10003
File net/disk_cache/backend_impl.cc (right):

http://codereview.chromium.org/2841034/diff/17001/10003#newcode442
net/disk_cache/backend_impl.cc:442: Trace("Backend destructor");
On 2010/07/01 22:46:09, nsylvain wrote:
> destructor?

sort of... (still running). Updated the text to "Backend Cleanup"

Powered by Google App Engine