Zlib compressor for Chromoting

Zlib compressor for Chromoting

A simple implementation of compressor using zlib.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51386

[dmac, 2010-07-01 00:12:54]

LGTM, but check out the comments.

http://codereview.chromium.org/2841032/diff/6001/7004
File remoting/base/compressor_zlib_unittest.cc (right):

http://codereview.chromium.org/2841032/diff/6001/7004#newcode17
remoting/base/compressor_zlib_unittest.cc:17: // bytes is consumed.
s/bytes/byte/

http://codereview.chromium.org/2841032/diff/6001/7004#newcode50
remoting/base/compressor_zlib_unittest.cc:50: Compress(&compressor, raw_data,
kRawDataSize,
there's actually no test here other than it doesn't crash. Do you want to try
testing it with a known data set as well to verify that you get the expected
values out? This may be overkill. Up to you.

[Alpha Left Google, 2010-07-01 00:14:57]

http://codereview.chromium.org/2841032/diff/6001/7004
File remoting/base/compressor_zlib_unittest.cc (right):

http://codereview.chromium.org/2841032/diff/6001/7004#newcode50
remoting/base/compressor_zlib_unittest.cc:50: Compress(&compressor, raw_data,
kRawDataSize,
On 2010/07/01 00:12:54, dmac wrote:
> there's actually no test here other than it doesn't crash. Do you want to try
> testing it with a known data set as well to verify that you get the expected
> values out? This may be overkill. Up to you.

The test will become invalid if zlib is updated and the compressed format
doesn't match.

I plan instead to do a compress + decompress test when I write the decompressor.

[dmac, 2010-07-01 00:24:27]

On 2010/07/01 00:14:57, Alpha wrote:
> http://codereview.chromium.org/2841032/diff/6001/7004
> File remoting/base/compressor_zlib_unittest.cc (right):
> 
> http://codereview.chromium.org/2841032/diff/6001/7004#newcode50
> remoting/base/compressor_zlib_unittest.cc:50: Compress(&compressor, raw_data,
> kRawDataSize,
> On 2010/07/01 00:12:54, dmac wrote:
> > there's actually no test here other than it doesn't crash. Do you want to
try
> > testing it with a known data set as well to verify that you get the expected
> > values out? This may be overkill. Up to you.
> 
> The test will become invalid if zlib is updated and the compressed format
> doesn't match.
> 
> I plan instead to do a compress + decompress test when I write the
decompressor.

Sounds good. LGTM.