Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: src/fast-codegen.cc

Issue 284009: Do not visit slots in the top-level code generator's backend.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/fast-codegen-arm.cc ('k') | src/ia32/fast-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 FunctionBoilerplateLiteral* expr) { 183 FunctionBoilerplateLiteral* expr) {
184 UNREACHABLE(); 184 UNREACHABLE();
185 } 185 }
186 186
187 187
188 void FastCodeGenerator::VisitConditional(Conditional* expr) { 188 void FastCodeGenerator::VisitConditional(Conditional* expr) {
189 UNREACHABLE(); 189 UNREACHABLE();
190 } 190 }
191 191
192 192
193 void FastCodeGenerator::VisitVariableProxy(VariableProxy* expr) { 193 void FastCodeGenerator::VisitSlot(Slot* expr) {
194 Comment cmnt(masm_, "[ VariableProxy"); 194 // Slots do not appear directly in the AST.
195 Expression* rewrite = expr->var()->rewrite(); 195 UNREACHABLE();
196 ASSERT(rewrite != NULL);
197
198 // Forward to the proxy's rewrite.
199 rewrite->set_location(expr->location());
200 Visit(rewrite);
201 } 196 }
202 197
203 198
204 void FastCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) { 199 void FastCodeGenerator::VisitRegExpLiteral(RegExpLiteral* expr) {
205 UNREACHABLE(); 200 UNREACHABLE();
206 } 201 }
207 202
208 203
209 void FastCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) { 204 void FastCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
210 UNREACHABLE(); 205 UNREACHABLE();
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 UNREACHABLE(); 260 UNREACHABLE();
266 } 261 }
267 262
268 263
269 void FastCodeGenerator::VisitThisFunction(ThisFunction* expr) { 264 void FastCodeGenerator::VisitThisFunction(ThisFunction* expr) {
270 UNREACHABLE(); 265 UNREACHABLE();
271 } 266 }
272 267
273 268
274 } } // namespace v8::internal 269 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/fast-codegen-arm.cc ('k') | src/ia32/fast-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698