Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 284009: Do not visit slots in the top-level code generator's backend.... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Do not visit slots in the top-level code generator's backend. Slots appear only indirectly in the AST (through variables linked to variable proxies). Slots are shared among variable references, so putting compilation-time state on them is potentially a source of bugs. Avoid it for now. Committed: http://code.google.com/p/v8/source/detail?r=3079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -27 lines) Patch
M src/arm/fast-codegen-arm.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M src/fast-codegen.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 chunk +13 lines, -6 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 chunk +13 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 2 months ago (2009-10-16 09:37:39 UTC) #1
fschneider
11 years, 2 months ago (2009-10-16 09:40:35 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698