Move context menu module out of experimental.

Move context menu module out of experimental.

BUG=48725, 39508
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52784

[Aaron Boodman, 2010-07-16 06:32:29]

asargent: code
kathyw: docs

[kathyw, 2010-07-16 15:15:07]

http://codereview.chromium.org/2840038/diff/1/45
File chrome/common/extensions/docs/static/contextMenus.html (right):

http://codereview.chromium.org/2840038/diff/1/45#newcode4
chrome/common/extensions/docs/static/contextMenus.html:4: to add items to
Chrome's context menu.
how about giving a little more information about what a context menu is?
maybe something like:

...to add items to the menu that comes up when
the user right-clicks (or Ctrl-right-clicks, on the Mac)
an HTML element controlled by the extension.

(not sure about that last line)

http://codereview.chromium.org/2840038/diff/1/45#newcode9
chrome/common/extensions/docs/static/contextMenus.html:9: your context menu
applies to,
it's not really "your" context menu, is it?
you're adding items to an already existing menu.
How about:

your context menu applies -> your context menu additions apply

http://codereview.chromium.org/2840038/diff/1/45#newcode17
chrome/common/extensions/docs/static/contextMenus.html:17: Chrome automatically
collapses them
Chrome -> Google Chrome

http://codereview.chromium.org/2840038/diff/1/45#newcode24
chrome/common/extensions/docs/static/contextMenus.html:24: Also, you should
specify a 16px icon
16px -> 16x16-pixel

http://codereview.chromium.org/2840038/diff/1/45#newcode37
chrome/common/extensions/docs/static/contextMenus.html:37: <b>"48":
"icon-small.png",</b>
Why is the 48 line bold, when the 16 line would seem to match what the paragraph
above said?

[asargent_no_longer_on_chrome, 2010-07-16 16:35:12]

code changes lgtm

[Aaron Boodman, 2010-07-16 20:27:52]

PTAL

http://codereview.chromium.org/2840038/diff/1/45
File chrome/common/extensions/docs/static/contextMenus.html (right):

http://codereview.chromium.org/2840038/diff/1/45#newcode4
chrome/common/extensions/docs/static/contextMenus.html:4: to add items to
Chrome's context menu.
On 2010/07/16 15:15:07, kathyw wrote:
> how about giving a little more information about what a context menu is?
> maybe something like:
> 
> ...to add items to the menu that comes up when
> the user right-clicks (or Ctrl-right-clicks, on the Mac)
> an HTML element controlled by the extension.
> 
> (not sure about that last line)

How about a picture instead? I can add one in a subsequent change.

http://codereview.chromium.org/2840038/diff/1/45#newcode9
chrome/common/extensions/docs/static/contextMenus.html:9: your context menu
applies to,
On 2010/07/16 15:15:07, kathyw wrote:
> it's not really "your" context menu, is it?
> you're adding items to an already existing menu.
> How about:
> 
> your context menu applies -> your context menu additions apply
> 

Done.

http://codereview.chromium.org/2840038/diff/1/45#newcode17
chrome/common/extensions/docs/static/contextMenus.html:17: Chrome automatically
collapses them
On 2010/07/16 15:15:07, kathyw wrote:
> Chrome -> Google Chrome

Done.

http://codereview.chromium.org/2840038/diff/1/45#newcode24
chrome/common/extensions/docs/static/contextMenus.html:24: Also, you should
specify a 16px icon
On 2010/07/16 15:15:07, kathyw wrote:
> 16px -> 16x16-pixel

Done.

http://codereview.chromium.org/2840038/diff/1/45#newcode37
chrome/common/extensions/docs/static/contextMenus.html:37: <b>"48":
"icon-small.png",</b>
On 2010/07/16 15:15:07, kathyw wrote:
> Why is the 48 line bold, when the 16 line would seem to match what the
paragraph
> above said?

Because i'm dumb. Fixed.

[kathyw, 2010-07-16 21:12:20]

One nit, other than that LGTM.

http://codereview.chromium.org/2840038/diff/1/45
File chrome/common/extensions/docs/static/contextMenus.html (right):

http://codereview.chromium.org/2840038/diff/1/45#newcode4
chrome/common/extensions/docs/static/contextMenus.html:4: to add items to
Chrome's context menu.
> How about a picture instead? I can add one in a subsequent change.

Sure, that'd be fine.

Also, "Chrome's" -> "Google Chrome's"