Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2840037: Valgrind Mac: Suppress ToolsSanityTest test cases on the Mac.... (Closed)

Created:
10 years, 5 months ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko, Hironori Bono
Visibility:
Public.

Description

Valgrind Mac: Suppress ToolsSanityTest test cases on the Mac. BUG=49253 TEST=none TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -13 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
10 years, 5 months ago (2010-07-16 02:42:38 UTC) #1
oshima
Lei, base unittest is failing because of this. I made the following cl, but not ...
10 years, 5 months ago (2010-07-22 17:43:31 UTC) #2
oshima
10 years, 5 months ago (2010-07-22 17:52:55 UTC) #3
I checked in
http://codereview.chromium.org/3033018
as a quick fix. let me know how you want to proceed.

On 2010/07/22 17:43:31, oshima wrote:
> Lei,
> 
> base unittest is failing because of this. I made the following cl, but not
sure
> if this is right approach. Please ping me when you're in.
> 
> http://codereview.chromium.org/3054007
> 
> On 2010/07/16 02:42:38, Lei Zhang wrote:
> >

Powered by Google App Engine
This is Rietveld 408576698