Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2020)

Issue 2840036: Moving Encoder and Decoder to remoting/base (Closed)

Created:
10 years, 5 months ago by Alpha Left Google
Modified:
9 years, 6 months ago
Reviewers:
dmac
CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, awong, garykac, Paweł Hajdan Jr., John Grabowski, pam+watch_chromium.org
Visibility:
Public.

Description

Moving Encoder and Decoder to remoting/base Putting Encder and Decoder together so we can have test that tests both of them. TEST=remoting_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53427

Patch Set 1 #

Patch Set 2 : added capturer back #

Total comments: 2

Patch Set 3 : add capture_data.h #

Patch Set 4 : merged #

Patch Set 5 : fix build #

Patch Set 6 : fixed other platforms #

Patch Set 7 : fix DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -155 lines) Patch
M chrome/service/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_process.cc View 2 chunks +1 line, -2 lines 0 comments Download
A remoting/base/capture_data.h View 1 chunk +75 lines, -0 lines 0 comments Download
A + remoting/base/decoder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/base/decoder_verbatim.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + remoting/base/decoder_verbatim.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/base/decoder_verbatim_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/base/encoder.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + remoting/base/encoder_verbatim.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + remoting/base/encoder_verbatim.cc View 5 chunks +16 lines, -14 lines 0 comments Download
A + remoting/base/encoder_vp8.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + remoting/base/encoder_vp8.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/base/encoder_vp8_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/base/mock_objects.h View 2 chunks +16 lines, -0 lines 0 comments Download
M remoting/client/mock_objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_view.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_view.cc View 5 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/x11_view.h View 5 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/x11_view.cc View 5 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/capturer.h View 1 2 chunks +1 line, -61 lines 0 comments Download
M remoting/host/capturer_fake.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_fake_ascii.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_gdi.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/capturer_mac_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/host/mock_objects.h View 2 chunks +0 lines, -14 lines 0 comments Download
M remoting/host/session_manager.h View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/host/session_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/session_manager_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M remoting/host/simple_host_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 5 5 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
This is just a refactoring to move Encoder and Decoder to base. This is necessary ...
10 years, 5 months ago (2010-07-15 19:47:08 UTC) #1
dmac
LGTM http://codereview.chromium.org/2840036/diff/3001/4006 File remoting/base/encoder_verbatim.cc (right): http://codereview.chromium.org/2840036/diff/3001/4006#newcode26 remoting/base/encoder_verbatim.cc:26: if (EncodeRect(dirty_rect.x(), dirty_rect.y(), dirty_rect.width(), out of curiosity why ...
10 years, 5 months ago (2010-07-15 20:07:49 UTC) #2
Alpha Left Google
10 years, 5 months ago (2010-07-15 20:10:13 UTC) #3
http://codereview.chromium.org/2840036/diff/3001/4006
File remoting/base/encoder_verbatim.cc (right):

http://codereview.chromium.org/2840036/diff/3001/4006#newcode26
remoting/base/encoder_verbatim.cc:26: if (EncodeRect(dirty_rect.x(),
dirty_rect.y(), dirty_rect.width(),
On 2010/07/15 20:07:49, dmac wrote:
> out of curiosity why split up the rectangle structure?

Because in the header file I don't want to include gfx.

Powered by Google App Engine
This is Rietveld 408576698