Attempt to fix ChromeFrame perf test failures on the experimental builder. Th...

Attempt to fix ChromeFrame perf test failures on the experimental builder. The test fails because of a crash while running
one of the chrome frame creation tests. This test causes a crash on the builder and it appears to occur because of multiple
chrome frame dlls being loaded in the process. One from the regular release\servers folder and the other one from the
reference build. 

Attempted fix is to add a sleep after the call to CoFreeUnusedLibraries to allow the currently loaded chrome frame binary
to unload.

TBR=amit


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51095

[amit, 2010-06-29 04:24:32]

ok

On Mon, Jun 28, 2010 at 8:23 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Attempt to fix ChromeFrame perf test failures on the experimental builder.
> The
> test fails because of a crash while running
> one of the chrome frame creation tests. This test causes a crash on the
> builder
> and it appears to occur because of multiple
> chrome frame dlls being loaded in the process. One from the regular
> release\servers folder and the other one from the
> reference build.
>
> Attempted fix is to add a sleep after the call to CoFreeUnusedLibraries to
> allow
> the currently loaded chrome frame binary
> to unload.
>
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/2840024/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/perf/chrome_frame_perftest.cc
>
>
> Index: chrome_frame/test/perf/chrome_frame_perftest.cc
> ===================================================================
> --- chrome_frame/test/perf/chrome_frame_perftest.cc     (revision 51084)
> +++ chrome_frame/test/perf/chrome_frame_perftest.cc     (working copy)
> @@ -792,6 +792,7 @@
>     PrintResults(test_name_.c_str());
>
>     CoFreeUnusedLibraries();
> +    PlatformThread::Sleep(100);
>   }
>
>   void NavigateImpl(const std::string& url) {
>
>
>