Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2840023: Update the ES5 conformance tests to the latest version and fix test... (Closed)

Created:
10 years, 5 months ago by Rico
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Update the ES5 conformance tests to the latest version and fix test expectations. We are currently using a rather old version of the ES5 conformance tests and there has been a range of bug fixes in the test set. This change brings us up to date. In addition, our current test expectations discards the all chapters but chapter 15. I have enabled the other chapters, cleaned up the tests that we no longer fail on, and filed bugs for tests that we fail on. It seems some of the bugs on the es5 conformance bug-tracker has been fixed but not marked fixed. I will file bugs for the newly discovered test bugs. Committed: http://code.google.com/p/v8/source/detail?r=4970

Patch Set 1 #

Total comments: 15

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -73 lines) Patch
M test/es5conform/README View 1 chunk +1 line, -1 line 0 comments Download
M test/es5conform/es5conform.status View 1 5 chunks +98 lines, -72 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
10 years, 5 months ago (2010-06-28 10:23:14 UTC) #1
Erik Corry
LGTM http://codereview.chromium.org/2840023/diff/1/3 File test/es5conform/es5conform.status (right): http://codereview.chromium.org/2840023/diff/1/3#newcode39 test/es5conform/es5conform.status:39: # We are compatible with safary and firefox. ...
10 years, 5 months ago (2010-06-28 11:15:43 UTC) #2
Rico
10 years, 5 months ago (2010-06-28 11:34:40 UTC) #3
http://codereview.chromium.org/2840023/diff/1/3
File test/es5conform/es5conform.status (right):

http://codereview.chromium.org/2840023/diff/1/3#newcode39
test/es5conform/es5conform.status:39: # We are compatible with safary and
firefox.
On 2010/06/28 11:15:43, Erik Corry wrote:
> Safari and Firefox

Done.

http://codereview.chromium.org/2840023/diff/1/3#newcode91
test/es5conform/es5conform.status:91: # Our Function object has a "arguments"
property which is used as a non
On 2010/06/28 11:15:43, Erik Corry wrote:
> has a -> has an
> non property -> non-property

Done.

http://codereview.chromium.org/2840023/diff/1/3#newcode96
test/es5conform/es5conform.status:96: # property in in the test.
On 2010/06/28 11:15:43, Erik Corry wrote:
> non property and again below.

Done.

http://codereview.chromium.org/2840023/diff/1/3#newcode230
test/es5conform/es5conform.status:230: # is no longer traversed.
On 2010/06/28 11:15:43, Erik Corry wrote:
> Is this a wrong test?
This test has actually been removed, I deleted the line.

http://codereview.chromium.org/2840023/diff/1/3#newcode257
test/es5conform/es5conform.status:257: # Wrong tests, path in test file is
wrong. This will chrash the test
On 2010/06/28 11:15:43, Erik Corry wrote:
> chrash -> crash

Done.

http://codereview.chromium.org/2840023/diff/1/3#newcode275
test/es5conform/es5conform.status:275: # RegExp.prototype is not of type RegExp
- we are bug compatible with safari.
On 2010/06/28 11:15:43, Erik Corry wrote:
> safari -> JSC
> or Safari
> and again below

Done.

http://codereview.chromium.org/2840023/diff/1/3#newcode291
test/es5conform/es5conform.status:291: # See
http://code.google.com/p/v8/issues/detail?id=753
On 2010/06/28 11:15:43, Erik Corry wrote:
> Please add a couple of words on the subject of the bug to jog people's memory.

Done.

Powered by Google App Engine
This is Rietveld 408576698