Issue 2840017: AppendASCII returns a new object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2840017: AppendASCII returns a new object. (Closed)

Created:
10 years, 6 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Scott Hess - ex-Googler

CC:
chromium-reviews, ben+cc_chromium.org, Paul Godavari, Paweł Hajdan Jr.

Visibility:
Public.

AppendASCII returns a new object. Found by clang. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50614

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	chrome/browser/safe_browsing/safe_browsing_database_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_store_sqlite_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

LGTM

Copy/paste for the ... FAIL!