Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2839006: Only copy libffmpegsumo if build_ffmpegsumo is 1. (Closed)

Created:
10 years, 6 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Only copy libffmpegsumo if build_ffmpegsumo is 1. BUG=none TEST=Build with build_libffmpegsumo=0 in ~/.gyp/include.gypi. Build should give no errors. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49982 Reverted

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M chrome/chrome_dll.gypi View 2 chunks +14 lines, -10 lines 5 comments Download

Messages

Total messages: 5 (0 generated)
Nico
10 years, 6 months ago (2010-06-16 18:00:00 UTC) #1
awong
LGTM
10 years, 6 months ago (2010-06-16 18:07:33 UTC) #2
Mark Mentovai
http://codereview.chromium.org/2839006/diff/1/2 File chrome/chrome_dll.gypi (right): http://codereview.chromium.org/2839006/diff/1/2#newcode527 chrome/chrome_dll.gypi:527: ['build_ffmpegsumo', { Fix CL description: build_ffmpegsumo vs. build_libffmpegsumo. http://codereview.chromium.org/2839006/diff/1/2#newcode527 ...
10 years, 6 months ago (2010-06-16 18:25:13 UTC) #3
Nico
http://codereview.chromium.org/2839006/diff/1/2 File chrome/chrome_dll.gypi (right): http://codereview.chromium.org/2839006/diff/1/2#newcode527 chrome/chrome_dll.gypi:527: ['build_ffmpegsumo', { On 2010/06/16 18:25:13, Mark Mentovai wrote: > ...
10 years, 6 months ago (2010-06-16 18:29:42 UTC) #4
Nico
10 years, 6 months ago (2010-06-16 19:35:19 UTC) #5
http://codereview.chromium.org/2839006/diff/1/2
File chrome/chrome_dll.gypi (right):

http://codereview.chromium.org/2839006/diff/1/2#newcode527
chrome/chrome_dll.gypi:527: ['build_ffmpegsumo', {
I used `git try`, but due to
http://code.google.com/p/chromium/issues/detail?id=46697 it didn't send what i
wanted it to, and i attributed the "update failed" to that. What could go wrong,
right? (even more than even you expected!)

On 2010/06/16 18:25:13, Mark Mentovai wrote:
> Where does the default value come from?

Is there a good way to do check build_ffmpegsumo then?

Powered by Google App Engine
This is Rietveld 408576698