Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2838042: Incorporating feedback from C++ readability review. (Closed)

Created:
10 years, 5 months ago by Raghu Simha
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, Raghu Simha, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Visibility:
Public.

Description

Incorporating feedback from C++ readability review. This changelist includes some minor fixes suggested during a C++ readability review. There are no code logic changes -- all edits are cosmetic. Review URL on Rietveld code review tool: http://codereview.appspot.com/1737041/show Buganizer URL for readability review: http://b/issue?id=2786642 BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51595

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing fwd declaration comments per Chromium norms. Also alphabetizing declarations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/test/live_sync/live_sync_test.h View 1 5 chunks +16 lines, -15 lines 0 comments Download
M chrome/test/live_sync/live_sync_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Raghu Simha
10 years, 5 months ago (2010-07-02 23:22:15 UTC) #1
ncarter (slow)
http://codereview.chromium.org/2838042/diff/1/3 File chrome/test/live_sync/live_sync_test.h (right): http://codereview.chromium.org/2838042/diff/1/3#newcode19 chrome/test/live_sync/live_sync_test.h:19: class Profile; // Declared in "chrome/browser/profile.h". Nowhere in Chrome ...
10 years, 5 months ago (2010-07-02 23:35:35 UTC) #2
Raghu Simha
http://codereview.chromium.org/2838042/diff/1/3 File chrome/test/live_sync/live_sync_test.h (right): http://codereview.chromium.org/2838042/diff/1/3#newcode19 chrome/test/live_sync/live_sync_test.h:19: class Profile; // Declared in "chrome/browser/profile.h". On 2010/07/02 23:35:35, ...
10 years, 5 months ago (2010-07-02 23:41:39 UTC) #3
ncarter (slow)
10 years, 5 months ago (2010-07-03 01:45:40 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698