Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 2838036: Disabling the ChromeFrame NavigationToRestrictedSite test as it causes IE8 to... (Closed)

Created:
10 years, 5 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Disabling the ChromeFrame NavigationToRestrictedSite test as it causes IE8 to not terminate at times leading to extract build failures. TBR=amit Bug=47596 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome_frame/test/test_mock_with_web_server.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 5 months ago (2010-07-01 02:01:33 UTC) #1
amit
10 years, 5 months ago (2010-07-01 05:39:01 UTC) #2
OK, but would it make sense to disable it just for IE8?

On Wed, Jun 30, 2010 at 7:01 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Disabling the ChromeFrame NavigationToRestrictedSite test as it causes IE8
> to
> not terminate at times leading to
> extract build failures.
>
> TBR=amit
> Bug=47596
>
>
> Please review this at http://codereview.chromium.org/2838036/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/test_mock_with_web_server.cc
>
>
> Index: chrome_frame/test/test_mock_with_web_server.cc
> ===================================================================
> --- chrome_frame/test/test_mock_with_web_server.cc      (revision 51300)
> +++ chrome_frame/test/test_mock_with_web_server.cc      (working copy)
> @@ -1278,7 +1278,9 @@
>   loop.RunFor(kChromeFrameLongNavigationTimeoutInSeconds * 2);
>  }
>
> -TEST(IEPrivacy, NavigationToRestrictedSite) {
> +// Test has been disabled as it causes the IE8 bot to hang at times.
> +// http://crbug.com/47596
> +TEST(IEPrivacy, DISABLED_NavigationToRestrictedSite) {
>   if (IsIBrowserServicePatchEnabled()) {
>     LOG(ERROR) << "Not running test. IBrowserServicePatch is in place.";
>     return;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698