Issue 2837002: Fixed VerifyFirmwarePreamble to check for a valid signing algorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2837002: Fixed VerifyFirmwarePreamble to check for a valid signing algorithm (Closed)

Created:
10 years, 6 months ago by Axel

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone, Randall Spangler, gauravsh

CC:
chromium-os-reviews_chromium.org

Base URL:
http://src.chromium.org/git/vboot_reference.git

Visibility:
Public.

Description

Fixed VerifyFirmwarePreamble to check for a valid signing algorithm Changed VerifyFirmwarePreamble to check for a valid kernel_subkey_sign_algorithm from the preamble. Originally, an incorrect kernel_subkey_sign_algorithm wouldn't be detected and could cause the RSA verification to read past the end of a buffer.