Issue 2837001: Make each solution dictionary an object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2837001: Make each solution dictionary an object. (Closed)

Created:
10 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Description

Make each solution dictionary an object. The change is partial to keep this change still correct but readable/reviewable. Followup changes will further move functions into the Dependency class. If it was done in one change, it would be unreviewable. Fix GetScmName() for protocol svn+ssh://. TEST=didn't break the smoke tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49707

Patch Set 1 #

Patch Set 2 : Include a fix in GetScmName() #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -50 lines)			Patch
	M	gclient.py	View		14 chunks	+79 lines, -49 lines	0 comments	Download
	M	gclient_scm.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages