Issue 2836088: base: rename Environment::SetEnv to Environment::SetVar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2836088: base: rename Environment::SetEnv to Environment::SetVar. (Closed)

Created:
10 years, 4 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, Paweł Hajdan Jr.

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, John Grabowski, Paweł Hajdan Jr., jam, pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

base: rename Environment::SetEnv to Environment::SetVar. This is the part 3 of this series. One more remaining. Splitting this into small parts, so it is more easy to review and reduce the size of the CL. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55168

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -21 lines)			Patch
M	app/l10n_util_unittest.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	base/environment.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/environment.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/environment_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	base/nss_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/xdg_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/locale_tests_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/shell_integration_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/zygote_host_linux.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/logging_chrome_uitest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/plugin/plugin_main_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/proxy/proxy_config_service_linux_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rubber stamp LGTM.

Expand Messages | Collapse Messages