Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2836082: Add two client certificates for use with unit tests (Closed)

Created:
10 years, 4 months ago by davidben
Modified:
9 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add two client certificates for use with unit tests The first is a FOAF.ME cert generated for this purpose. The second is one of my expired MIT certificates. R=wtc BUG=50980 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54650

Patch Set 1 #

Patch Set 2 : Add a README file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
A net/data/ssl/certificates/README View 1 chunk +30 lines, -0 lines 2 comments Download
A net/data/ssl/certificates/foaf.me.chromium-test-cert.der View Binary file 0 comments Download
A net/data/ssl/certificates/mit.davidben.der View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
10 years, 4 months ago (2010-08-02 22:58:47 UTC) #1
wtc
LGTM. We may want to add a README file to explain what each file is. ...
10 years, 4 months ago (2010-08-02 23:06:24 UTC) #2
davidben
On 2010/08/02 23:06:24, wtc wrote: > LGTM. > > We may want to add a ...
10 years, 4 months ago (2010-08-02 23:48:08 UTC) #3
wtc
Thanks for adding the README file. LGTM! http://codereview.chromium.org/2836082/diff/4001/5001 File net/data/ssl/certificates/README (right): http://codereview.chromium.org/2836082/diff/4001/5001#newcode11 net/data/ssl/certificates/README:11: - thawte.single.pem ...
10 years, 4 months ago (2010-08-02 23:58:58 UTC) #4
davidben
10 years, 4 months ago (2010-08-03 00:07:48 UTC) #5
http://codereview.chromium.org/2836082/diff/4001/5001
File net/data/ssl/certificates/README (right):

http://codereview.chromium.org/2836082/diff/4001/5001#newcode11
net/data/ssl/certificates/README:11: - thawte.single.pem :: Certificates for
testing parsing of different formats.
On 2010/08/02 23:58:59, wtc wrote:
> Why do you use the :: notation?

It's the convention for emacs org-mode. We don't seem to have much of
conventions for READMEs (?), and it seemed as good as any. Meh. I'm not attached
to it.

Powered by Google App Engine
This is Rietveld 408576698