Issue 2836076: Use ConfigureWifiService() instead of GetWifiService()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2836076: Use ConfigureWifiService() instead of GetWifiService() (Closed)

Created:
10 years, 4 months ago by Nathan Williams

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, rginda, gauravsh

Base URL:
ssh://git@chromiumos-git/entd.git

Visibility:
Public.

Description

Use ConfigureWifiService() instead of GetWifiService() to avoid the side-effect of creating a hidden network. BUG=4822 (CL 3 of 3) TEST=Set up enterprise policy and certificates, then log in where Google or Google-A network is not present. Confirm that those do not appear in the network menu, and that no services or networks with that name are currently known by flimflam (via list-services and list-networks).

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -18 lines)			Patch
	M	flimflam.cc	View		2 chunks	+6 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nathan Williams

See the flimflam and libcros CLs just posted for the other context.

10 years, 4 months ago (2010-07-30 16:04:27 UTC) #1

LGTM, once the other CLs land

Expand Messages | Collapse Messages