chrome: create an option for using libcros provided in the system...

chrome: create an option for using libcros provided by the system; fix all
includes referring to libcros to not include third_party/

* Headers fix is needed to support using system libcros (installed to /usr/include)
and DEPS include rule updated

* All includes are "", and therefore a local variant in third_party/cros/ is
always preferred, but system will also get picked up as a secondary target

* Fixed chrome/browser/chromeos/cros/synaptics_library.h comments to better
reflect the header placement

* Added a variable system_libcros defaulting to 0
* Gotten rid of duplicate cros_api.gyp
* Changed both places to either link against cros_api or libcrosapi

TEST=build in the following scenarios:
1) libcros not installed, libcros sources in third_party/, !defined system_libcros
 - sucess
2) installed libcros, put #error into /usr/include/cros/chromeos_cros_api.h, repeat 1)
 - success
3) BUILD_DEFINES+=system_libcros=1, removed libcros from third_party, repeat 2)
 - fail (on #error in chromeos_cros_api.h)
4) Installed clean libcros, repeat 3)
 - success

Main changes:
M      chrome/browser/chromeos/input_method/candidate_window.gyp
M      chrome/chrome_browser.gypi
M      build/common.gypi
D      chrome/browser/chromeos/cros/cros_api.gyp

Header fixes:
M      chrome/browser/views/extensions/extension_popup.cc
M      chrome/browser/views/browser_bubble_gtk.cc
M      chrome/browser/views/info_bubble.cc
M      chrome/browser/chromeos/panels/panel_browsertest.cc
M      chrome/browser/chromeos/login/background_view.cc
M      chrome/browser/chromeos/login/screen_locker.cc
M      chrome/browser/chromeos/login/user_controller.cc
M      chrome/browser/chromeos/login/wizard_controller.cc
M      chrome/browser/chromeos/frame/browser_view.cc
M      chrome/browser/chromeos/frame/panel_controller.cc
M      chrome/browser/chromeos/options/language_config_model.h
MM     chrome/browser/chromeos/wm_overview_title.cc
M      chrome/browser/chromeos/input_method/candidate_window.cc
MM     chrome/browser/chromeos/wm_overview_fav_icon.cc
M      chrome/browser/chromeos/google_update_chromeos.cc
M      chrome/browser/chromeos/cros/cros_in_process_browser_test.h
M      chrome/browser/chromeos/cros/login_library.h
M      chrome/browser/chromeos/cros/update_library.h
M      chrome/browser/chromeos/cros/screen_lock_library.h
M      chrome/browser/chromeos/cros/cryptohome_library.h
M      chrome/browser/chromeos/cros/power_library.h
M      chrome/browser/chromeos/cros/input_method_library.h
M      chrome/browser/chromeos/cros/keyboard_library.h
M      chrome/browser/chromeos/cros/mock_mount_library.h
M      chrome/browser/chromeos/cros/synaptics_library.h
M      chrome/browser/chromeos/cros/speech_synthesis_library.cc
M      chrome/browser/chromeos/cros/system_library.h
M      chrome/browser/chromeos/cros/network_library.h
M      chrome/browser/chromeos/cros/cros_library_loader.cc
M      chrome/browser/chromeos/cros/keyboard_library.cc
M      chrome/browser/chromeos/cros/mount_library.h
M      chrome/browser/chromeos/cros/syslogs_library.h
M      chrome/browser/chromeos/wm_ipc.h
M      chrome/browser/chromeos/system_key_event_listener.cc
M      chrome/browser/chromeos/DEPS

[zel, 2010-07-19 23:39:16]

LGTM

[zel, 2010-07-19 23:39:44]

On 2010/07/19 23:39:16, zel wrote:
> LGTM

Please delete chrome/browser/chromeos/cros/cros_api.gyp file as well

[zel, 2010-07-19 23:54:02]

actually, few more things still missing

http://codereview.chromium.org/2836058/diff/1/3
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/2836058/diff/1/3#newcode3487
chrome/chrome_browser.gypi:3487: ['system_libcros==0', {
system_libcros need to be defined properly in src/build/common.gypi file. As an
example, please look at chromeos variable there. The default value should be 0.

Then, you will have to add 'system_libcros=1' to BUILD_DEFINES in
chromeos-chrome ebuild file (both private and chromium)

[zel, 2010-07-20 00:19:20]

LGTM

[zel, 2010-07-20 16:13:22]

Hey, where is the rest of the files (header changes)? They don't seem to be
uploaded.

[zbehan, 2010-07-20 18:54:17]

Oh wow, I did the change and was so put to sleep by the successful change of
description that I didn't upload. :/

Those differences between git cl and gcl always get me. Sorry. New one
should be up.

On Tue, Jul 20, 2010 at 9:13 AM, <zelidrag@chromium.org> wrote:

> Hey, where is the rest of the files (header changes)? They don't seem to be
> uploaded.
>
>
> http://codereview.chromium.org/2836058/show
>