Issue 2836053: Turn OmahaRequestPrepAction into OmahaRequestDeviceParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2836053: Turn OmahaRequestPrepAction into OmahaRequestDeviceParams. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Turn OmahaRequestPrepAction into OmahaRequestDeviceParams. Pass the params to OmahaRequestAction's ctor. This simplifies a bit executing as well as testing of OmahaRequestAction and testing of OmahaRequestDeviceParams. It also allows us to initialize the params once per update attempt and use them for all OmahaRequestActions. BUG=560 TEST=unit tests, gmerged on device and forced an update through dev server, inspected logs.

Patch Set 1 #

Patch Set 2 : Update copyrights. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+212 lines, -280 lines)			Patch
M	SConstruct	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	main.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	omaha_request_action.h	View	1	5 chunks	+10 lines, -56 lines	0 comments	Download
M	omaha_request_action.cc	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	omaha_request_action_unittest.cc	View	1	7 chunks	+20 lines, -23 lines	0 comments	Download
A	omaha_request_params.h	View	1	1 chunk	+97 lines, -0 lines	0 comments	Download
A +	omaha_request_params.cc	View	1	7 chunks	+27 lines, -39 lines	0 comments	Download
A +	omaha_request_params_unittest.cc	View	1	13 chunks	+24 lines, -52 lines	0 comments	Download
D	omaha_request_prep_action.h	View		1 chunk	+0 lines, -75 lines	0 comments	Download
M	update_attempter.h	View		5 chunks	+12 lines, -10 lines	0 comments	Download
M	update_attempter.cc	View		9 chunks	+12 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

Take a look. I find this inheritance approach clean but it may be walking into ...

10 years, 5 months ago (2010-07-15 17:00:45 UTC) #1

LGTM

Expand Messages | Collapse Messages