Issue 2836043: Relocate library files for wider access and re-use; also associated cleanup.

Issue 2836043: Relocate library files for wider access and re-use; also associated cleanup. (Closed)

Created:
10 years, 5 months ago by Tammo Spalink

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, Nick Sanders, Hung-Te, trchen, Tom Wai-Hong Tam

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org

Base URL:
ssh://gitrw.chromium.org/autotest.git

Visibility:
Public.

Description

Relocate library files for wider access and re-use; also associated cleanup. Putting the factories in bin better matches other auotest files, and allows for better (simpler) access by both the control files and the ui. This in turn allows for us to avoid sending the TestData code definition between processes, which was very ugly. With all the code sharing libs, the logging function was also cleaned up.

Patch Set 1 #

Patch Set 2 : patch typo #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1010 lines, -994 lines)			Patch
A	client/bin/factory.py	View		1 chunk	+101 lines, -0 lines	0 comments	Download
A +	client/bin/factory_ui	View		22 chunks	+54 lines, -77 lines	0 comments	Download
A	client/bin/factory_ui_lib.py	View		1 chunk	+110 lines, -0 lines	0 comments	Download
D	client/common_lib/factory_test.py	View		1 chunk	+0 lines, -94 lines	0 comments	Download
M	client/site_tests/factory_Camera/factory_Camera.py	View	1	6 chunks	+18 lines, -12 lines	0 comments	Download
D	client/site_tests/factory_DeveloperRecovery/DevRecTest.py	View		1 chunk	+0 lines, -316 lines	0 comments	Download
M	client/site_tests/factory_DeveloperRecovery/factory_DeveloperRecovery.py	View		1 chunk	+311 lines, -24 lines	0 comments	Download
M	client/site_tests/factory_Display/factory_Display.py	View		8 chunks	+32 lines, -55 lines	0 comments	Download
M	client/site_tests/factory_Dummy/factory_Dummy.py	View		2 chunks	+22 lines, -17 lines	0 comments	Download
M	client/site_tests/factory_ExternalStorage/factory_ExternalStorage.py	View		6 chunks	+17 lines, -19 lines	0 comments	Download
D	client/site_tests/factory_Keyboard/KeyboardTest.py	View		1 chunk	+0 lines, -159 lines	0 comments	Download
M	client/site_tests/factory_Keyboard/factory_Keyboard.py	View		2 chunks	+148 lines, -13 lines	0 comments	Download
M	client/site_tests/factory_RebootStub/factory_RebootStub.py	View		1 chunk	+6 lines, -9 lines	0 comments	Download
A	client/site_tests/factory_ScriptWrapper/dummy.sh	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	client/site_tests/factory_ScriptWrapper/factory_ScriptWrapper.py	View		4 chunks	+45 lines, -37 lines	0 comments	Download
M	client/site_tests/factory_Touchpad/factory_Touchpad.py	View		9 chunks	+26 lines, -21 lines	0 comments	Download
M	client/site_tests/suite_Factory/control	View	1	6 chunks	+113 lines, -141 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tammo Spalink

This is really: http://codereview.chromium.org/2805052/show which was rolled back because it broke the build. This fixes ...

10 years, 5 months ago (2010-07-02 10:43:56 UTC) #1

LGTM

Expand Messages | Collapse Messages