Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2836036: Rewrite gen_fuzz_test_cases.sh script to use new signing utilities. (Closed)

Created:
10 years, 5 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Base URL:
ssh://git@chromiumos-git/vboot_reference.git
Visibility:
Public.

Description

Rewrite gen_fuzz_test_cases.sh script to use new signing utilities. TEST=Generated images verify successfully using right keys.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Clean up patch. #

Patch Set 3 : Cleanup. 80 char. #

Patch Set 4 : review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -32 lines) Patch
M tests/gen_fuzz_test_cases.sh View 1 2 3 1 chunk +54 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gauravsh
gen_fuzz_test_cases.sh is the only file that is a part of this. It picked up the ...
10 years, 5 months ago (2010-06-30 00:22:52 UTC) #1
gauravsh
Clean ups.
10 years, 5 months ago (2010-06-30 00:52:58 UTC) #2
Randall Spangler
http://codereview.chromium.org/2836036/diff/1/3 File tests/gen_fuzz_test_cases.sh (right): http://codereview.chromium.org/2836036/diff/1/3#newcode22 tests/gen_fuzz_test_cases.sh:22: function generate_keyblocks { generate_pubkeys http://codereview.chromium.org/2836036/diff/1/3#newcode50 tests/gen_fuzz_test_cases.sh:50: ${UTIL_DIR}/vbutil_keyblock --pack ${TESTCASE_DIR}/kernel.keyblock ...
10 years, 5 months ago (2010-06-30 01:05:33 UTC) #3
gauravsh
http://codereview.chromium.org/2836036/diff/1/3 File tests/gen_fuzz_test_cases.sh (right): http://codereview.chromium.org/2836036/diff/1/3#newcode22 tests/gen_fuzz_test_cases.sh:22: function generate_keyblocks { On 2010/06/30 01:05:33, Randall Spangler wrote: ...
10 years, 5 months ago (2010-06-30 01:15:28 UTC) #4
Randall Spangler
10 years, 5 months ago (2010-06-30 01:43:20 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698