Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: src/heap.cc

Issue 2836026: Don't make any decisions on old space limits after scavenges. (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index 9d6e13a6536868c4ae72e6890a5c2f8ecd717610..32ebf544879acc418717681dfa152d71cbb33c7d 100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -131,7 +131,6 @@ int Heap::high_survival_rate_period_length_ = 0;
double Heap::survival_rate_ = 0;
Heap::SurvivalRateTrend Heap::previous_survival_rate_trend_ = Heap::STABLE;
Heap::SurvivalRateTrend Heap::survival_rate_trend_ = Heap::STABLE;
-bool Heap::bumped_old_gen_limits_ = false;
#ifdef DEBUG
bool Heap::allocation_allowed_ = true;
@@ -666,7 +665,6 @@ void Heap::PerformGarbageCollection(AllocationSpace space,
// space for the mutation speed.
old_gen_promotion_limit_ *= 2;
old_gen_allocation_limit_ *= 2;
- bumped_old_gen_limits_ = true;
}
old_gen_exhausted_ = false;
@@ -676,19 +674,6 @@ void Heap::PerformGarbageCollection(AllocationSpace space,
tracer_ = NULL;
UpdateSurvivalRateTrend(start_new_space_size);
-
- if (bumped_old_gen_limits_ &&
- !IsHighSurvivalRate() &&
- !IsIncreasingSurvivalTrend()) {
- // We previously observed high survival rates in young space and decided
- // to bump old space allocation limits to trade the space for the speed
- // but now survival rates are dropping which indicates that mutator
- // finished updating tenured data structure. So we can decrease old space
- // limits to guarantee an early full GC cycle and reduce memory footprint.
- old_gen_promotion_limit_ /= 2;
- old_gen_allocation_limit_ /= 2;
- bumped_old_gen_limits_ = false;
- }
}
Counters::objs_since_last_young.Set(0);
« no previous file with comments | « src/heap.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698