Issue 2836021: Only flush code when there are no heap allocated locals in the scopeinfo....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2836021: Only flush code when there are no heap allocated locals in the scopeinfo.... (Closed)

Created:
10 years, 6 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Only flush code when there are no heap allocated locals in the scopeinfo. When flushing code we can potentially flush code with a scopeinfo that we later need to resolve variables. This makes an explicit check that there are heap allocated locals in the scopeinfo. Committed: http://code.google.com/p/v8/source/detail?r=4921

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
M	src/heap.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/scopeinfo.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/scopeinfo.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/2836021/diff/5001/6001 File src/heap.cc (right): http://codereview.chromium.org/2836021/diff/5001/6001#newcode2270 src/heap.cc:2270: if ( ScopeInfo<>::HasHeapAllocatedLocals(function_info->code())) Remove space before ScopeInfo.

10 years, 6 months ago (2010-06-23 07:14:27 UTC) #2

Rico

10 years, 6 months ago (2010-06-23 07:16:00 UTC) #3

http://codereview.chromium.org/2836021/diff/5001/6001
File src/heap.cc (right):

http://codereview.chromium.org/2836021/diff/5001/6001#newcode2270
src/heap.cc:2270: if (
ScopeInfo<>::HasHeapAllocatedLocals(function_info->code()))
On 2010/06/23 07:14:27, Kasper Lund wrote:
> Remove space before ScopeInfo.

Done.

Expand Messages | Collapse Messages