-. Add new variables for multi dll build:...

-. Add new variables for multi dll build:
   1. multi_dll_build: whether or not to build multi dll version.
   2. component: used for library that can be built as DLL.
        component is set to shared_library if multi_dll_build==1,
        in other cases, it is set to "<(library)".
-. Fix win_use_allocator_shim comments and some MSVCRT related settings.

Note: this patch just adds new variables. They are not ready to use yet.

R=darin
BUG=46311
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50362

[darin (slow to review), 2010-06-18 18:46:34]

LGTM.  You should probably get a review from maruel too.

http://codereview.chromium.org/2836013/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/2836013/diff/1/2#newcode127
build/common.gypi:127: 'multi_dll_build%': 0,
is "multi_dll_build" meant to be a windows only variable?

[Victor Wang, 2010-06-18 18:54:24]

On 2010/06/18 18:46:34, darin wrote:
> LGTM.  You should probably get a review from maruel too.
> 
> http://codereview.chromium.org/2836013/diff/1/2
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/2836013/diff/1/2#newcode127
> build/common.gypi:127: 'multi_dll_build%': 0,
> is "multi_dll_build" meant to be a windows only variable?
We could extend this variable to other platforms, may be change it to be more
generic like multi_shared_library_build? or you have better suggestion on the
name...

[M-A Ruel, 2010-06-18 18:57:26]

http://codereview.chromium.org/2836013/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/2836013/diff/1/2#newcode127
build/common.gypi:127: 'multi_dll_build%': 0,
On 2010/06/18 18:46:35, darin wrote:
> is "multi_dll_build" meant to be a windows only variable?

It'd be nice if it could reuse 'library' but I guess it's impossible for now.

http://codereview.chromium.org/2836013/diff/1/2#newcode696
build/common.gypi:696: 'msvs_disabled_warnings': [4275],
No, you need to enable exceptions instead and remove the define
'_HAS_EXCEPTIONS=0'.

I'm surprised lines 745~750 got in, the exception is relevant.

[darin (slow to review), 2010-06-18 20:24:33]

On Fri, Jun 18, 2010 at 11:54 AM, <victorw@chromium.org> wrote:

> On 2010/06/18 18:46:34, darin wrote:
>
>> LGTM.  You should probably get a review from maruel too.
>>
>
>  http://codereview.chromium.org/2836013/diff/1/2
>> File build/common.gypi (right):
>>
>
>  http://codereview.chromium.org/2836013/diff/1/2#newcode127
>> build/common.gypi:127: 'multi_dll_build%': 0,
>> is "multi_dll_build" meant to be a windows only variable?
>>
> We could extend this variable to other platforms, may be change it to be
> more
> generic like multi_shared_library_build? or you have better suggestion on
> the
> name...
>
>
>
What about using the word "component" somehow since this is meant
to influence whether component = static_library or shared_library, right?

-Darin



>
>
> http://codereview.chromium.org/2836013/show
>

[Victor Wang, 2010-06-19 04:32:03]

http://codereview.chromium.org/2836013/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/2836013/diff/1/2#newcode696
build/common.gypi:696: 'msvs_disabled_warnings': [4275],
On 2010/06/18 18:57:26, Marc-Antoine Ruel wrote:
> No, you need to enable exceptions instead and remove the define
> '_HAS_EXCEPTIONS=0'.
> 
> I'm surprised lines 745~750 got in, the exception is relevant.

Done.

[Victor Wang, 2010-06-19 04:39:13]

On 2010/06/18 20:24:33, darin wrote:
> On Fri, Jun 18, 2010 at 11:54 AM, <mailto:victorw@chromium.org> wrote:
> 
> > On 2010/06/18 18:46:34, darin wrote:
> >
> >> LGTM.  You should probably get a review from maruel too.
> >>
> >
> >  http://codereview.chromium.org/2836013/diff/1/2
> >> File build/common.gypi (right):
> >>
> >
> >  http://codereview.chromium.org/2836013/diff/1/2#newcode127
> >> build/common.gypi:127: 'multi_dll_build%': 0,
> >> is "multi_dll_build" meant to be a windows only variable?
> >>
> > We could extend this variable to other platforms, may be change it to be
> > more
> > generic like multi_shared_library_build? or you have better suggestion on
> > the
> > name...
> >
> >
> >
> What about using the word "component" somehow since this is meant
> to influence whether component = static_library or shared_library, right?
> 
> -Darin
> 
> 
> 
> >
> >
> > http://codereview.chromium.org/2836013/show
> >
> 

I moved "library" and "component" variables one scope in so "component" could be
used for condition and is set to "<(library)" by default.
Updated the rest of code to check "component" value instead of adding another
variable for this.

[darin (slow to review), 2010-06-19 20:05:58]

LGTM (the mac and linux try bot failures look unrelated)

http://codereview.chromium.org/2836013/diff/9001/5002
File build/common.gypi (right):

http://codereview.chromium.org/2836013/diff/9001/5002#newcode128
build/common.gypi:128: # Varaible 'component' is for cases where we would like
to build some
nit: Varaible -> Variable

[Victor Wang, 2010-06-19 21:00:39]

http://codereview.chromium.org/2836013/diff/9001/5002
File build/common.gypi (right):

http://codereview.chromium.org/2836013/diff/9001/5002#newcode128
build/common.gypi:128: # Varaible 'component' is for cases where we would like
to build some
On 2010/06/19 20:05:58, darin wrote:
> nit: Varaible -> Variable

Done.

[M-A Ruel, 2010-06-21 17:27:31]

lgtm with one nit, that looks cool

http://codereview.chromium.org/2836013/diff/10002/12001
File build/common.gypi (right):

http://codereview.chromium.org/2836013/diff/10002/12001#newcode422
build/common.gypi:422: # See
http://msdn.microsoft.com/en-us/library/aa652367(VS.71).aspx
http://msdn.microsoft.com/en-us/library/aa652367.aspx