chrome/browser/cocoa/history_menu_bridge_unittest.mm - Issue 2836008: Make the HistoryMenuBridge::HistoryItem co-own the NSMenuItem. This hopefully fixes a top-crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/history_menu_bridge_unittest.mm

Issue 2836008: Make the HistoryMenuBridge::HistoryItem co-own the NSMenuItem. This hopefully fixes a top-crash. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/history_menu_bridge_unittest.mm

diff --git a/chrome/browser/cocoa/history_menu_bridge_unittest.mm b/chrome/browser/cocoa/history_menu_bridge_unittest.mm

index 0d23906e153f20869694b88d20cd1b5660580f4b..1fd47a2390c39d66a5a6a9f8b19a95f99e9daa58 100644

--- a/chrome/browser/cocoa/history_menu_bridge_unittest.mm

+++ b/chrome/browser/cocoa/history_menu_bridge_unittest.mm

@@ -369,8 +369,7 @@ TEST_F(HistoryMenuBridgeTest, GotFaviconData) {

// Set up the HistoryItem.

HistoryMenuBridge::HistoryItem item;

- scoped_nsobject<NSMenuItem> menu_item([[NSMenuItem alloc] init]);

- item.menu_item = menu_item.get();

+ item.menu_item.reset([[NSMenuItem alloc] init]);

GetFaviconForHistoryItem(&item);

// Pretend to be called back.

« chrome/browser/cocoa/history_menu_bridge.mm ('K') | « chrome/browser/cocoa/history_menu_bridge.mm ('k') | no next file » | no next file with comments »