chrome/browser/cocoa/history_menu_bridge.h - Issue 2836008: Make the HistoryMenuBridge::HistoryItem co-own the NSMenuItem. This hopefully fixes a top-crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/history_menu_bridge.h

Issue 2836008: Make the HistoryMenuBridge::HistoryItem co-own the NSMenuItem. This hopefully fixes a top-crash. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/history_menu_bridge.h

diff --git a/chrome/browser/cocoa/history_menu_bridge.h b/chrome/browser/cocoa/history_menu_bridge.h

index ef84031876ffeae739fc29cf1dbf2577c9e74c87..b02b75a18f78ee30ccc1bad43e918a220a80e9e3 100644

--- a/chrome/browser/cocoa/history_menu_bridge.h

+++ b/chrome/browser/cocoa/history_menu_bridge.h

@@ -88,8 +88,12 @@ class HistoryMenuBridge : public NotificationObserver,

// The Handle given to us by the FaviconService for the icon fetch request.

FaviconService::Handle icon_handle;

- // The pointer to the item after it has been created. Weak.

- NSMenuItem* menu_item;

+ // The pointer to the item after it has been created. This is co-owned with

+ // the NSMenu, but during a rebuild flood (if the user closes a lot of tabs

John Grabowski 2010/06/17 19:30:44 This is co-owned with the NSMenu. but ... --> Str

+ // quickly), the NSMenu can release the item before the HistoryItem has

+ // been fully deleted. If this were a weak pointer, it would result in a

+ // zombie.

+ scoped_nsobject<NSMenuItem> menu_item;

// This ID is unique for a browser session and can be passed to the

// TabRestoreService to re-open the closed window or tab that this

« no previous file with comments | « no previous file | chrome/browser/cocoa/history_menu_bridge.mm » ('j') | chrome/browser/cocoa/history_menu_bridge.mm » ('J')